Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use Object.hasOwn() in util doc #41780

Merged
merged 1 commit into from
Jan 31, 2022
Merged

doc: use Object.hasOwn() in util doc #41780

merged 1 commit into from
Jan 31, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 31, 2022

Swtich from hasOwnProperty() to Object.hasOwn().

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module. labels Jan 31, 2022
@Trott Trott added dont-land-on-v12.x fast-track PRs that do not need to wait for 48 hours to land. labels Jan 31, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott
doc: use Object.hasOwn() in util doc
3c2d0df 
Swtich from `hasOwnProperty()` to `Object.hasOwn()`.
@Trott Trott changed the title doc: use Objec t.hasOwn in util doc doc: use Object.hasOwn() in util doc Jan 31, 2022
benjamingr
benjamingr approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to assume this is for the eslint rule to run on the docs?

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 31, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2022
@nodejs-github-bot nodejs-github-bot merged commit 4fbe9e5 into nodejs:master Jan 31, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 4fbe9e5

@Trott Trott deleted the hasowndoc branch January 31, 2022 22:33
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@Trott @ruyadorno
doc: use Object.hasOwn() in util doc
032df4e 
Swtich from `hasOwnProperty()` to `Object.hasOwn()`.

PR-URL: #41780
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@Trott @danielleadams
doc: use Object.hasOwn() in util doc
3813e2b 
Swtich from `hasOwnProperty()` to `Object.hasOwn()`.

PR-URL: #41780
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Trott @danielleadams
doc: use Object.hasOwn() in util doc
1763239 
Swtich from `hasOwnProperty()` to `Object.hasOwn()`.

PR-URL: #41780
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
doc: use Object.hasOwn() in util doc
14ea8fc 
Swtich from `hasOwnProperty()` to `Object.hasOwn()`.

PR-URL: #41780
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mesteery Mesteery Mesteery approved these changes

@aduh95 aduh95 aduh95 approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @benjamingr @aduh95 @Mesteery